Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: pigweed/pigweed
Branch: main
commit 8dfb6ef0937612fa318a8312c7ac3ad02b1a3325
Author: Eric Rahm <erahm@google.com>
Date: Mon May 06 21:35:48 2024
pw_bluetooth: Disable emboss enum traits
This disables generating enum traits across the bazel, gn, and cmake
builds of `pw_bluetooth`. By disabling enum traits we remove a
dependency on `sscanf` and reduce the generated code size by several
megabytes.
Fixed: 339029458
Test:
bazel test //pw_bluetooth/...
pw presubmit --step gn_chre_googletest_nanopb_sapphire_build
pw presubmit --step cmake_clang
Change-Id: If5a25f6460403ef6908ffc561ffc6a644580d8d3
Reviewed-on:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/208591
Reviewed-by: Ben Lawson <benlawson@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Commit-Queue: Eric Rahm <erahm@google.com>
M pw_bluetooth/BUILD.bazel
M third_party/emboss/build_defs.gni
M third_party/emboss/emboss.cmake
https://pigweed-review.git.corp.google.com/208591
Branch: main
commit 8dfb6ef0937612fa318a8312c7ac3ad02b1a3325
Author: Eric Rahm <erahm@google.com>
Date: Mon May 06 21:35:48 2024
pw_bluetooth: Disable emboss enum traits
This disables generating enum traits across the bazel, gn, and cmake
builds of `pw_bluetooth`. By disabling enum traits we remove a
dependency on `sscanf` and reduce the generated code size by several
megabytes.
Fixed: 339029458
Test:
bazel test //pw_bluetooth/...
pw presubmit --step gn_chre_googletest_nanopb_sapphire_build
pw presubmit --step cmake_clang
Change-Id: If5a25f6460403ef6908ffc561ffc6a644580d8d3
Reviewed-on:
Reviewed-by: Ben Lawson <benlawson@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Commit-Queue: Eric Rahm <erahm@google.com>
M pw_bluetooth/BUILD.bazel
M third_party/emboss/build_defs.gni
M third_party/emboss/emboss.cmake
Description
Emboss now allows disabling the generation of enum traits with the
--no-cc-enum-traits
flag as well as thebazel
enable_enum_traits
attribute for the theemboss_cc_library
declaration.Disabling enum traits will reduce the generated code-size by several megabytes and also removes dependencies on various text processing functions such as
sscanf
.