Assigned
Status Update
Comments
am...@google.com <am...@google.com> #2
Does this require tweaks to presubmit checks?
ap...@google.com <ap...@google.com> #3
Project: pigweed/pigweed
Branch: main
commit b482f964bd56b7ffb7ba4cbd1f8e1c3ed82345cf
Author: Erik Gilling <konkers@google.com>
Date: Wed Feb 14 18:26:24 2024
pw_presubmit: Allow markdown style TODOs and adjust rustdocs
Bug: b/315389119
Change-Id: I4ebb580a4b58424aacc9cf4e3029dc12b0090e41
Reviewed-on:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/192253
Pigweed-Auto-Submit: Erik Gilling <konkers@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Armando Montanez <amontanez@google.com>
M pw_log/rust/pw_log.rs
M pw_log/rust/pw_log_backend_api.rs
M pw_log/rust/pw_log_backend_printf.rs
M pw_log/rust/pw_log_backend_println.rs
M pw_presubmit/docs.rst
M pw_presubmit/py/pw_presubmit/todo_check.py
M pw_presubmit/py/todo_check_test.py
https://pigweed-review.git.corp.google.com/192253
Branch: main
commit b482f964bd56b7ffb7ba4cbd1f8e1c3ed82345cf
Author: Erik Gilling <konkers@google.com>
Date: Wed Feb 14 18:26:24 2024
pw_presubmit: Allow markdown style TODOs and adjust rustdocs
Bug:
Change-Id: I4ebb580a4b58424aacc9cf4e3029dc12b0090e41
Reviewed-on:
Pigweed-Auto-Submit: Erik Gilling <konkers@google.com>
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Presubmit-Verified: CQ Bot Account <pigweed-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Armando Montanez <amontanez@google.com>
M pw_log/rust/
M pw_log/rust/
M pw_log/rust/
M pw_log/rust/
M pw_presubmit/docs.rst
M pw_presubmit/py/pw_presubmit/todo_check.py
M pw_presubmit/py/todo_check_test.py
Description
Rust is complaining about some link formatting, these warnings should probably be silenced.