Pigweed

/* Thanks for filing a bug report or feature request in the Pigweed Open Source issue tracker. These reports are public and visible at bugs.pigweed.dev. All new reports default to P3, you can adjust to a higher priority if the issue has a significant impact on your project. To select a different priority please use the template menu above. Here are some suggested fields to include in your report */

What were you trying to do:

Building with pw_string.to_string using a CMake based project.

Steps followed:

Linking against pw_string.to_string. Build with clang on host.

Expected result:

Should compile.

Actual result:

[6/78] Building CXX object pigweed/pw_string/CMakeFiles/pw_string.to_string.dir/type_to_string.cc.obj
FAILED: pigweed/pw_string/CMakeFiles/pw_string.to_string.dir/type_to_string.cc.obj
C:\PROGRA~2\MICROS~4\2022\BUILDT~1\VC\Tools\Llvm\x64\bin\CLANG_~1.EXE -D_BITS_BYTESWAP_H -D_CRT_SECURE_NO_WARNINGS -D__GNUC__ -IC:/Users/fasx1039/work/acb_workspace/mithril_acb/host -IC:/Users/fasx1039/work/acb_workspace/mithril_acb/host/../../zephyr/include -IC:/Users/fasx1039/work/acb_workspace/mithril_acb/host/../build/zephyr/include/generated -IC:/Users/fasx1039/work/acb_workspace/mithril_acb/host/../build/mithril_acb/zephyr/include/generated -IC:/Users/fasx1039/work/acb_workspace/mithril_acb/host/../../modules/hal_cmsis/CMSIS/Core/Include -IC:/Users/fasx1039/work/acb_workspace/mithril_acb/host/../../modules/zephyr_ext/modules -IC:/Users/fasx1039/work/acb_workspace/mithril_acb/host/../../modules/zephyr_ext/drivers/include -IC:/Users/fasx1039/work/acb_workspace/mithril_acb/host/../../modules/zephyr_ext/boards/arm/pbb409500_h742vi -IC:/Users/fasx1039/work/acb_workspace/modules/pigweed/pw_string/public -IC:/Users/fasx1039/work/acb_workspace/modules/pigweed/pw_preprocessor/public -IC:/Users/fasx1039/work/acb_workspace/modules/pigweed/pw_span/public -IC:/Users/fasx1039/work/acb_workspace/modules/pigweed/pw_assert/public -IC:/Users/fasx1039/work/acb_workspace/modules/pigweed/pw_assert/print_and_abort_check_public_overrides -IC:/Users/fasx1039/work/acb_workspace/modules/pigweed/pw_assert/print_and_abort_assert_public_overrides -IC:/Users/fasx1039/work/acb_workspace/modules/pigweed/pw_polyfill/standard_library_public -IC:/Users/fasx1039/work/acb_workspace/modules/pigweed/pw_status/public -IC:/Users/fasx1039/work/acb_workspace/modules/pigweed/pw_polyfill/public -IC:/Users/fasx1039/work/acb_workspace/modules/pigweed/pw_result/public -IC:/Users/fasx1039/work/acb_workspace/modules/pigweed/third_party/fuchsia/repo/sdk/lib/stdcompat/include -std=c++20 -O0 -g -Xclang -gcodeview -D_DEBUG -D_DLL -D_MT -Xclang --dependent-lib=msvcrtd -Wall -Wextra -Wimplicit-fallthrough -Wundef -Wpointer-arith -Werror -Wno-error=cpp -Wno-error=deprecated-declarations -Wnon-virtual-dtor -Wshadow -Wredundant-decls -Wpedantic -Wno-c++20-designator -Wno-gnu-zero-variadic-macro-arguments -imacros autoconf.h -Wno-macro-redefined -m32 -g -fcolor-diagnostics -fno-common -fno-exceptions -ffunction-sections -fdata-sections -fno-rtti -std=gnu++20 -MD -MT pigweed/pw_string/CMakeFiles/pw_string.to_string.dir/type_to_string.cc.obj -MF pigweed\pw_string\CMakeFiles\pw_string.to_string.dir\type_to_string.cc.obj.d -o pigweed/pw_string/CMakeFiles/pw_string.to_string.dir/type_to_string.cc.obj -c C:/Users/fasx1039/work/acb_workspace/modules/pigweed/pw_string/type_to_string.cc
C:/Users/fasx1039/work/acb_workspace/modules/pigweed/pw_string/type_to_string.cc:29:36: error: constexpr variable cannot have non-literal type 'const std::array<uint64_t, 20>' (aka 'const array<unsigned long long, 20>')
constexpr std::array<uint64_t, 20> kPowersOf10{
                                   ^
C:/Users/fasx1039/work/acb_workspace/modules/pigweed/pw_string/type_to_string.cc:29:36: error: implicit instantiation of undefined template 'std::array<unsigned long long, 20>'
C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools\VC\Tools\MSVC\14.36.32532\include\utility:144:7: note: template is declared here
class array;
      ^
2 errors generated.

It seems an #include <array> is missing in type_to_string.cc.

Host environment:

Clang 15, Windows

Target Device:

N/A

Please keep discussions respectful and constructive. See our code of conduct. Visit pigweed.dev for info about joining our Discord group and Pigweed Live events.