Pigweed

Since this is likely a build system change, Ted, I think you are best fit for this.

I gave this a try, now that we can generate all the proto libraries. Unfortunately, I run into problems importing the pw_log modules.

http://pwrev.dev/195128 is the change that adds pw_system_console support in the examples repo. I run,

$ bazel run //examples/01-blinky:console
INFO: Running command line: bazel-bin/examples/01-blinky/console.exe -d /dev/ttyACM0 -b 115200 examples/01-blinky/blinky.elf
Traceback (most recent call last):
  File "/home/tpudlik/.cache/bazel/_bazel_tpudlik/3203ecbef1955d44b68a3ed425cfe6cb/execroot/__main__/bazel-out/k8-fastbuild/bin/examples/01-blinky/console.exe.runfiles/__main__/tools/sample_project_tools/console.py", line 21, in <module>
    import pw_system.console
  File "/home/tpudlik/.cache/bazel/_bazel_tpudlik/3203ecbef1955d44b68a3ed425cfe6cb/execroot/__main__/bazel-out/k8-fastbuild/bin/examples/01-blinky/console.exe.runfiles/pigweed/pw_system/py/pw_system/console.py", line 66, in <module>
    from pw_system import device as pw_device
  File "/home/tpudlik/.cache/bazel/_bazel_tpudlik/3203ecbef1955d44b68a3ed425cfe6cb/execroot/__main__/bazel-out/k8-fastbuild/bin/examples/01-blinky/console.exe.runfiles/pigweed/pw_system/py/pw_system/device.py", line 23, in <module>
    from pw_log import log_decoder
ImportError: cannot import name 'log_decoder' from 'pw_log' (/home/tpudlik/.cache/bazel/_bazel_tpudlik/3203ecbef1955d44b68a3ed425cfe6cb/execroot/__main__/bazel-out/k8-fastbuild/bin/examples/01-blinky/console.exe.runfiles/__main__/external/pigweed/pw_log/_virtual_imports/log_proto/pw_log/__init__.py)

The relevant py_library is in the deps. The problem is that Python gets stuck looking for the pure Python code in the generated-code directory of the pw_log protos. I had hoped http://pwrev.dev/193641 would fix this, but it looks like that's not quite the case :/.

bazel test //pw_log/py:log_decoder_test passes, so this should theoretically work. Also, --incompatible_default_to_explicit_init_py should be disabling the generation of these __init__.py files. Perhaps we need to update rules_python?

Also, amusingly, "it works for me" on macOS. 🤔

Ah, that is indeed the issue; the sample project doesn't yet have --incompatible_default_to_explicit_init_py enabled.

Thanks Armando, #comment8 was the missing piece!

I verified that the Bazel-built console works with the example 01 project (http://pwrev.dev/195128), so this is now Fixed. Yay!