Regression: Undefined identifier pw_env_setup_CIPD_PIGWEED [294886611]

Fixed

Bug

Status Update

No update yet.

Description

ks...@apple.com

created issue #1

Aug 7, 2023 11:08PM

Not a Contribution

Pigweed commit 0889de6 (pw_toolchain: Make tools use relative paths) regressed the ability to use the pigweed build in an environment where pw_env_setup has not been run, because it references a build variable (pw_env_setup_CIPD_PIGWEED) that may not have been defined:

ERROR at //third_party/connectedhomeip/third_party/pigweed/repo/pw_toolchain/clang_tools.gni:26:31: Undefined identifier
 pw_toolchain_CLANG_PREFIX = pw_env_setup_CIPD_PIGWEED + "/bin/"

This breaks our lightweight Matter SDK build flavor that bypasses the pigweed bootstrap.

Comments

bl...@google.com <bl...@google.com> #2Aug 7, 2023 11:23PM

Assigned to ca...@google.com.

Automated by Blunderbuss job pigweed-blunderbuss-autoassigner for component 1194524.

ca...@google.com <ca...@google.com> Aug 7, 2023 11:30PM

Reassigned to am...@google.com.

mo...@google.com <mo...@google.com> #3Aug 8, 2023 03:57PM

Change in question: https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/159130

Message last modified on Aug 8, 2023 03:59PM

am...@google.com <am...@google.com> Aug 8, 2023 04:18PM

Accepted by am...@google.com.

ap...@google.com <ap...@google.com> #4Aug 8, 2023 06:57PM

Project: pigweed/pigweed
Branch: main

commit 02f2811d2c47ad6fbb029c7b48c82f757cc4ec4a
Author: Armando Montanez <amontanez@google.com>
Date: Tue Aug 08 18:56:07 2023

pw_toolchain: Optionally depend on pw_env_setup_CIPD_PIGWEED

Changes clang_tools.gni to only generate a relative path prefix for
CIPD-provided tools if pw_env_setup_CIPD_PIGWEED is set.

Bug:

b/294886611

Change-Id: I219119d298b8ad3c91306ed174b8313e82b3cb61
Reviewed-on:

https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/163790
Commit-Queue: Auto-Submit <auto-submit@pigweed-service-accounts.iam.gserviceaccount.com>
Pigweed-Auto-Submit: Armando Montanez <amontanez@google.com>
Reviewed-by: Rob Mohr <mohrr@google.com>

M pw_toolchain/clang_tools.gni

https://pigweed-review.git.corp.google.com/163790

am...@google.com <am...@google.com> #5Aug 9, 2023 04:16PM

Marked as fixed.

Should be fixed, feel free to reopen if the issue persists.

ks...@apple.com <ks...@apple.com> #6Aug 14, 2023 02:28AM

Thanks for the quick turnaround!