Fixed
Status Update
No update yet.
Comments
he...@google.com
Started implementation in
he...@google.com
ap...@google.com
Project: pigweed/pigweed
Branch: main
commit 9e90af3746446e4aaaa0ccc5dd2079cf60d744a1
Author: Wyatt Hepler <hepler@google.com>
Date: Fri Apr 26 20:13:18 2024
pw_thread: Use pw::Function to start threads
Fixes:
Change-Id: I355ad4581d00a745415dd4ab140f6e08cbf40c27
Reviewed-on:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/205760
Reviewed-by: Wyatt Hepler <hepler@google.com>
Commit-Queue: Taylor Cramer <cramertj@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
M docs/BUILD.gn
M pw_rpc/callback_test.cc
M pw_rpc/nanopb/callback_test.cc
M pw_rpc/public/pw_rpc/internal/client_server_testing_threaded.h
M pw_thread/BUILD.bazel
M pw_thread/BUILD.gn
M pw_thread/CMakeLists.txt
A pw_thread/deprecated_or_new_thread_function_test.cc
M pw_thread/docs.rst
A pw_thread/public/pw_thread/deprecated_or_new_thread_function.h
M pw_thread/public/pw_thread/thread.h
M pw_thread/test_thread_context_facade_test.cc
M pw_thread/thread.cc
M pw_thread/thread_facade_test.cc
M pw_thread_embos/BUILD.bazel
M pw_thread_embos/BUILD.gn
M pw_thread_embos/public/pw_thread_embos/context.h
M pw_thread_embos/public/pw_thread_embos/options.h
M pw_thread_embos/thread.cc
M pw_thread_freertos/BUILD.bazel
M pw_thread_freertos/BUILD.gn
M pw_thread_freertos/CMakeLists.txt
M pw_thread_freertos/public/pw_thread_freertos/context.h
M pw_thread_freertos/public/pw_thread_freertos/options.h
M pw_thread_freertos/thread.cc
M pw_thread_stl/public/pw_thread_stl/thread_inline.h
M pw_thread_threadx/BUILD.bazel
M pw_thread_threadx/BUILD.gn
M pw_thread_threadx/public/pw_thread_threadx/context.h
M pw_thread_threadx/public/pw_thread_threadx/options.h
M pw_thread_threadx/thread.cc
M pw_thread_zephyr/CMakeLists.txt
M pw_thread_zephyr/public/pw_thread_zephyr/context.h
M pw_thread_zephyr/public/pw_thread_zephyr/options.h
M pw_thread_zephyr/thread.cc
https://pigweed-review.git.corp.google.com/205760
Branch: main
commit 9e90af3746446e4aaaa0ccc5dd2079cf60d744a1
Author: Wyatt Hepler <hepler@google.com>
Date: Fri Apr 26 20:13:18 2024
pw_thread: Use pw::Function to start threads
Fixes:
Change-Id: I355ad4581d00a745415dd4ab140f6e08cbf40c27
Reviewed-on:
Reviewed-by: Wyatt Hepler <hepler@google.com>
Commit-Queue: Taylor Cramer <cramertj@google.com>
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
M docs/BUILD.gn
M pw_rpc/callback_test.cc
M pw_rpc/nanopb/callback_test.cc
M pw_rpc/public/pw_rpc/internal/client_server_testing_threaded.h
M pw_thread/BUILD.bazel
M pw_thread/BUILD.gn
M pw_thread/CMakeLists.txt
A pw_thread/deprecated_or_new_thread_function_test.cc
M pw_thread/docs.rst
A pw_thread/public/pw_thread/deprecated_or_new_thread_function.h
M pw_thread/public/pw_thread/thread.h
M pw_thread/test_thread_context_facade_test.cc
M pw_thread/thread.cc
M pw_thread/thread_facade_test.cc
M pw_thread_embos/BUILD.bazel
M pw_thread_embos/BUILD.gn
M pw_thread_embos/public/pw_thread_embos/context.h
M pw_thread_embos/public/pw_thread_embos/options.h
M pw_thread_embos/thread.cc
M pw_thread_freertos/BUILD.bazel
M pw_thread_freertos/BUILD.gn
M pw_thread_freertos/CMakeLists.txt
M pw_thread_freertos/public/pw_thread_freertos/context.h
M pw_thread_freertos/public/pw_thread_freertos/options.h
M pw_thread_freertos/thread.cc
M pw_thread_stl/public/pw_thread_stl/thread_inline.h
M pw_thread_threadx/BUILD.bazel
M pw_thread_threadx/BUILD.gn
M pw_thread_threadx/public/pw_thread_threadx/context.h
M pw_thread_threadx/public/pw_thread_threadx/options.h
M pw_thread_threadx/thread.cc
M pw_thread_zephyr/CMakeLists.txt
M pw_thread_zephyr/public/pw_thread_zephyr/context.h
M pw_thread_zephyr/public/pw_thread_zephyr/options.h
M pw_thread_zephyr/thread.cc
ap...@google.com
[Details redacted due to bug visibility]
Change-Id: Iaf349aa416308b637e9d3a6aeb4c87ca9d7e8140
https://turquoise-internal-review.googlesource.com/836398
Change-Id: Iaf349aa416308b637e9d3a6aeb4c87ca9d7e8140
ap...@google.com
Project: fuchsia
Branch: main
commit 8445406fd00dbc6cd36362ffcf0366e722fd71dc
Author: global-integration-roller <global-integration-roller@fuchsia-infra.iam.gserviceaccount.com>
Date: Fri Apr 26 22:08:08 2024
[superproject] Roll third_party/pigweed pw_thread: Use pw::Function to start threads
Fixes:
Original-Reviewed-on:https://pigweed-review.googlesource.com/c/pigweed/pigweed/+/205760
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Original-Revision: 9e90af3746446e4aaaa0ccc5dd2079cf60d744a1
GitOrigin-RevId: a0f4a5b7201eeb1969916277916fe15edc98f0fb
Roller-URL:https://ci.chromium.org/b/8749557027987625329
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I9205523f5b1dcb5b48c4aeebe437e02f0389610d
Reviewed-on:https://fuchsia-review.googlesource.com/c/fuchsia/+/1037893
M third_party/pigweed/src
https://fuchsia-review.googlesource.com/1037893
Branch: main
commit 8445406fd00dbc6cd36362ffcf0366e722fd71dc
Author: global-integration-roller <global-integration-roller@fuchsia-infra.iam.gserviceaccount.com>
Date: Fri Apr 26 22:08:08 2024
[superproject] Roll third_party/pigweed pw_thread: Use pw::Function to start threads
Fixes:
Original-Reviewed-on:
Lint: Lint 🤖 <android-build-ayeaye@system.gserviceaccount.com>
Original-Revision: 9e90af3746446e4aaaa0ccc5dd2079cf60d744a1
GitOrigin-RevId: a0f4a5b7201eeb1969916277916fe15edc98f0fb
Roller-URL:
CQ-Do-Not-Cancel-Tryjobs: true
Change-Id: I9205523f5b1dcb5b48c4aeebe437e02f0389610d
Reviewed-on:
M third_party/pigweed/src
ap...@google.com
[Details redacted due to bug visibility]
Change-Id: I878232eb7f4f33bf33e769f409f161175dba3b6e
https://turquoise-internal-review.googlesource.com/836426
Change-Id: I878232eb7f4f33bf33e769f409f161175dba3b6e
Description
The
ThreadAPI currently accepts a function pointer and avoid*argument. Now thatpw::Functionis fully realized, we should updatepw::thread::Threadto take apw::Function.